Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Database support for Gauge #185
Structurally I am concerned about how the code is being added to Gauge. Gauge should just throw updates at watchers, and watchers are where the code for handling pushing to the database should be. IE gauge shouldnt need to import anything to do with the database.
Also, you should build new watchers for use with couch db rather than modifying existing ones to also send stats to couch. At the moment this will crash in the REANNZ office because we are not using couchdb so when it tries to open its config file I'll get an Exception. You need to leave the existing watchers as they are.
Furthermore the config should come in through config.py. watcher.py shouldnt be parsing config. I would also suggest that you should just use the new config format, so your db config can all be included in gauge.yaml.
So structurally the only files you should really need to touch is watcher.py and config.py. There may also be some minor changes to how gauge.py handles adding and removing dps so that your watchers can monitor that effectively. But mostly I would expect to see that you would add a GaugeFlowTableCouchPoller class and maybe a GaugeDPCouchLogger.
I'll add inline comments to sorta clarify what I mean.
It would be better if the architecture and model is documented in
On Mon, Aug 29, 2016 at 7:54 PM, KitL firstname.lastname@example.org wrote: