Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit, integration and generative tests to github from travis #3609

Merged
merged 1 commit into from Jul 2, 2020

Conversation

mab68
Copy link
Contributor

@mab68 mab68 commented Jun 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #3609 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3609      +/-   ##
==========================================
+ Coverage   92.33%   92.34%   +0.01%     
==========================================
  Files          46       46              
  Lines        8253     8253              
==========================================
+ Hits         7620     7621       +1     
+ Misses        633      632       -1     
Impacted Files Coverage Δ
faucet/valve_util.py 83.91% <0.00%> (-1.15%) ⬇️
faucet/config_parser_util.py 91.38% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b326f...d9ec49f. Read the comment docs.

@gizmoguy
Copy link
Member

gizmoguy commented Jun 10, 2020

Hey @mab68 just some early feedback on this WIP PR.

I wonder if we might be better off taking this opportunity to investigate writing new simpler bash scripts for booting the github actions (or even just putting all the job definition in the github workflow yaml) instead of trying to emulate all the travis environment variables.

@mab68
Copy link
Contributor Author

mab68 commented Jun 11, 2020

@gizmoguy

Pretty sure I've got the github actions to mimic the Travis behaviour, so if worst comes to worst we can use that option.

I will investigate using the github workflow more.

@mab68 mab68 force-pushed the generative-actions branch 4 times, most recently from 439a537 to 96d6dd6 Compare June 19, 2020 03:25
@mab68 mab68 force-pushed the generative-actions branch 5 times, most recently from ff241cf to 18d8193 Compare June 22, 2020 05:15
@mab68 mab68 changed the title WIP: Move generative tests to github from travis Move generative tests to github from travis Jun 22, 2020
@mab68 mab68 force-pushed the generative-actions branch 7 times, most recently from 6a2f79b to f4e4103 Compare June 23, 2020 22:47
@mab68
Copy link
Contributor Author

mab68 commented Jun 24, 2020

Hey @gizmoguy, I think this should be good to go now.

@gizmoguy
Copy link
Member

Concept looks good to me.

I see GitHub actions is emitting some warnings on your workflow definition, did you want to take a look at that?

 .github#L1

Received event from pull_request, but also received a before(f4e410346b2c90c44e8f0101f722ee02f3368726) or after(d9ec49f56a56f571782f37de896632a07fd5ed46) value.
 I am assuming you want to use a Push event but forgot something, so I'm giving you a message.

@mab68
Copy link
Contributor Author

mab68 commented Jun 26, 2020

Concept looks good to me.

I see GitHub actions is emitting some warnings on your workflow definition, did you want to take a look at that?

 .github#L1

Received event from pull_request, but also received a before(f4e410346b2c90c44e8f0101f722ee02f3368726) or after(d9ec49f56a56f571782f37de896632a07fd5ed46) value.
 I am assuming you want to use a Push event but forgot something, so I'm giving you a message.

This is a problem with the file-changes-action. When a pull request is updated, it causes a pull-request synchronize event to occur which contains both the before & after information, which the action does not expect. I'll submit an issue to the action repository about this. I could not find anyway of suppressing the warning, short of writing the file change code myself or having another step to fall back to in this situation.

@gizmoguy gizmoguy changed the title Move generative tests to github from travis Move unit, integration and generative tests to github from travis Jun 29, 2020
@gizmoguy
Copy link
Member

#3230

@gizmoguy gizmoguy merged commit bc23eb7 into faucetsdn:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants