New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move unit, integration and generative tests to github from travis #3609
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3609 +/- ##
==========================================
+ Coverage 92.33% 92.34% +0.01%
==========================================
Files 46 46
Lines 8253 8253
==========================================
+ Hits 7620 7621 +1
+ Misses 633 632 -1
Continue to review full report at Codecov.
|
Hey @mab68 just some early feedback on this WIP PR. I wonder if we might be better off taking this opportunity to investigate writing new simpler bash scripts for booting the github actions (or even just putting all the job definition in the github workflow yaml) instead of trying to emulate all the travis environment variables. |
c3a934a
to
7cfd9e6
Compare
Pretty sure I've got the github actions to mimic the Travis behaviour, so if worst comes to worst we can use that option. I will investigate using the github workflow more. |
439a537
to
96d6dd6
Compare
ff241cf
to
18d8193
Compare
6a2f79b
to
f4e4103
Compare
f4e4103
to
d9ec49f
Compare
Hey @gizmoguy, I think this should be good to go now. |
Concept looks good to me. I see GitHub actions is emitting some warnings on your workflow definition, did you want to take a look at that?
|
This is a problem with the file-changes-action. When a pull request is updated, it causes a pull-request synchronize event to occur which contains both the before & after information, which the action does not expect. I'll submit an issue to the action repository about this. I could not find anyway of suppressing the warning, short of writing the file change code myself or having another step to fall back to in this situation. |
No description provided.