From 70446480bff49dc93cd33427dd00a8744ab5bb51 Mon Sep 17 00:00:00 2001 From: Paul Paterson Date: Wed, 30 Jun 2021 19:36:40 -0400 Subject: [PATCH] LABS-24: Remove Now from Index bindings --- src/fauna/queries/fweets.js | 9 ++++++--- src/fauna/setup/followerstats.js | 2 +- src/fauna/setup/fweets.js | 10 +--------- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/src/fauna/queries/fweets.js b/src/fauna/queries/fweets.js index 152f532..1ef88c6 100644 --- a/src/fauna/queries/fweets.js +++ b/src/fauna/queries/fweets.js @@ -108,7 +108,8 @@ function LikeFweet(fweetRef) { fweet: fweetRef, like: Var('newLikeStatus'), refweet: false, - comment: false + comment: false, + created: Now() } }) ), @@ -170,7 +171,8 @@ function Refweet(fweetRef, message, tags) { fweet: fweetRef, like: false, refweet: true, - comment: false + comment: false, + created: Now() } }) ), @@ -235,7 +237,8 @@ function Comment(fweetRef, message) { fweet: fweetRef, like: false, refweet: false, - comment: true + comment: true, + created: Now() } }) ), diff --git a/src/fauna/setup/followerstats.js b/src/fauna/setup/followerstats.js index 58d68a7..08b6b30 100644 --- a/src/fauna/setup/followerstats.js +++ b/src/fauna/setup/followerstats.js @@ -72,7 +72,7 @@ const CreateIndexByUserPopularity = CreateIndex({ refweetsfactor: 1, postlikes: Select(['data', 'postlikes'], Var('stats')), postrefweets: Select(['data', 'postrefweets'], Var('stats')), - txtime: Now(), + txtime: Select(['data', 'created'], Var('stats')), unixstarttime: Time('1970-01-01T00:00:00+00:00'), ageInSecsSinceUnix: TimeDiff(Var('unixstarttime'), Var('txtime'), 'minutes') }, diff --git a/src/fauna/setup/fweets.js b/src/fauna/setup/fweets.js index 215b297..3eedac3 100644 --- a/src/fauna/setup/fweets.js +++ b/src/fauna/setup/fweets.js @@ -135,15 +135,7 @@ const CreateIndexFweetsByTag = CreateIndex({ likes: Select(['data', 'likes'], Var('fweet')), comments: Select(['data', 'comments'], Var('fweet')), refweets: Select(['data', 'refweets'], Var('fweet')), - - // DISCLAIMER !!!! - // Now() should not be used in bindings since it does not provide correct results, - // Something I did not know at the time of writing. - // Instead please use either a created_at time you store on the document - // or an updated time instead. We'll update the app from the moment I find time to test - // an alternative approach. - - txtime: Now(), + txtime: Select(['data', 'created'], Var('fweet')), unixstarttime: Time('1970-01-01T00:00:00+00:00'), ageInSecsSinceUnix: TimeDiff(Var('unixstarttime'), Var('txtime'), 'minutes') },