Browse files

usb: gadget: pch_udc: Fix wrong return value

If the return value of pch_udc_pcd_init() is False, the return value of
this function is unsettled.
Since pch_udc_pcd_init() always returns 0, there is not actually the issue.

If pch_udc_pcd_init() is True, the variable, retval, is not set for an
appropriate value.

Signed-off-by: Tomoya MORINAGA <>
Signed-off-by: Felipe Balbi <>
  • Loading branch information...
Tomoya MORINAGA Felipe Balbi
Tomoya MORINAGA authored and Felipe Balbi committed Jan 12, 2012
1 parent c50a3bf commit c802672cd36cd063bfd54d54c8c34825ab5b2357
Showing with 3 additions and 1 deletion.
  1. +3 −1 drivers/usb/gadget/pch_udc.c
@@ -2915,8 +2915,10 @@ static int pch_udc_probe(struct pci_dev *pdev,
pch_udc = dev;
/* initialize the hardware */
- if (pch_udc_pcd_init(dev))
+ if (pch_udc_pcd_init(dev)) {
+ retval = -ENODEV;
goto finished;
+ }
if (request_irq(pdev->irq, pch_udc_isr, IRQF_SHARED, KBUILD_MODNAME,
dev)) {
dev_err(&pdev->dev, "%s: request_irq(%d) fail\n", __func__,

0 comments on commit c802672

Please sign in to comment.