New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make CPANTS and POD::Coverage happy : ) #1

Merged
merged 1 commit into from Jul 4, 2016

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Jul 4, 2016

  • Use MetaJSON plugin (Happy CPANTS)
  • Specify minimum perl version (5.004) (Happy CPANTS)
  • Add bare POD setup_installer and check_file_version methods (Happy POD::Coverage)
  • Tidy up CheckChangeLog.pm
  • Add .gitignore

@fayland I think there's more we should do with this PR but wanted to discuss with you before going further. Specifically, I think we need to add tests for the plugin and tidy up some more.

Make CPANTS and POD::Coverage happy : )
 - Use MetaJSON plugin (Happy CPANTS)
 - Specify minimum perl version (5.004) (Happy CPANTS)
 - Add bare POD setup_installer and check_file_version
   methods POD::Coverage was complaining about
 - Tidy up CheckChangeLog.pm
 - Add .gitignore
@fayland

This comment has been minimized.

Show comment
Hide comment
@fayland

fayland Jul 4, 2016

Owner

hi, I'm OK with that, I can give you co-maint permission if you like that. Thanks

Owner

fayland commented Jul 4, 2016

hi, I'm OK with that, I can give you co-maint permission if you like that. Thanks

@fayland fayland merged commit 0dc5434 into fayland:master Jul 4, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 5, 2016

@fayland Sure :) I forgot to mention this dist was assigned to me as part of the CPAN PR Challenge.

Please don't do a release on this until we get some more test units in place.

ghost commented Jul 5, 2016

@fayland Sure :) I forgot to mention this dist was assigned to me as part of the CPAN PR Challenge.

Please don't do a release on this until we get some more test units in place.

@fayland

This comment has been minimized.

Show comment
Hide comment
@fayland

fayland Jul 5, 2016

Owner

OK, don't forget to update the Changes. 👍

Owner

fayland commented Jul 5, 2016

OK, don't forget to update the Changes. 👍

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 5, 2016

@fayland will do my friend : )

ghost commented Jul 5, 2016

@fayland will do my friend : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment