Add missing prereqs to match use #20

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
5 participants
@paultcochrane
Contributor

paultcochrane commented Nov 9, 2016

The kwalitee tests on
CPANTS
show that some modules are used but not declared as prerequisites. This
change brings code up to date and thus closes the prereq_matches_use
CPANTS core issue for this distribution.

If anything needs changing in this PR, please just let me know and I'll update it appropriately and resubmit.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 9, 2016

Coverage Status

Coverage remained the same at 99.412% when pulling 6765dd3 on paultcochrane:pr/add-missing-prereqs into bdd9125 on fayland:master.

Coverage Status

Coverage remained the same at 99.412% when pulling 6765dd3 on paultcochrane:pr/add-missing-prereqs into bdd9125 on fayland:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 9, 2016

Coverage Status

Coverage remained the same at 99.412% when pulling 6765dd3 on paultcochrane:pr/add-missing-prereqs into bdd9125 on fayland:master.

coveralls commented Nov 9, 2016

Coverage Status

Coverage remained the same at 99.412% when pulling 6765dd3 on paultcochrane:pr/add-missing-prereqs into bdd9125 on fayland:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 9, 2016

Current coverage is 95.88% (diff: 100%)

Merging #20 into master will increase coverage by 2.48%

@@             master        #20   diff @@
==========================================
  Files            14         11     -3   
  Lines           197        170    -27   
  Methods           0          0          
  Messages          0          0          
  Branches         26         17     -9   
==========================================
- Hits            184        163    -21   
  Misses            1          1          
+ Partials         12          6     -6   

Powered by Codecov. Last update 30727f0...6765dd3

codecov-io commented Nov 9, 2016

Current coverage is 95.88% (diff: 100%)

Merging #20 into master will increase coverage by 2.48%

@@             master        #20   diff @@
==========================================
  Files            14         11     -3   
  Lines           197        170    -27   
  Methods           0          0          
  Messages          0          0          
  Branches         26         17     -9   
==========================================
- Hits            184        163    -21   
  Misses            1          1          
+ Partials         12          6     -6   

Powered by Codecov. Last update 30727f0...6765dd3

tklein and others added some commits Sep 21, 2016

Added support for GitLab CI and coverage badges
* TODO there might be issues with badges on different branches
Fix minor grammar and sentence flow issues in POD
There were a couple of places where a verb was missing from a sentence and
other places where a shorter sentence flowed better and was clearer.
Extend Perl versions tested on Travis
Travis can handle up to Perl 5.24 at present, hence up to at least this
version should be tested.
Declare minimum Perl version
Although `Perl::MinimumVersion` reports 5.8.5 as the minimum Perl
version, I chose 5.14 here because of 1561d01, which restricted the
Travis tests to this minimum version.
Add Test::Pod test dependency
After having built a pristine Perl with perlbrew it turned out that
after having installed all the dependencies via `cpanm --installdeps .`
that the `Test::Pod` module was still required in order to run `dzil
test`.  This patch adds `Test::Pod` to the list of test dependencies so
that this issue doesn't happen to someone else.
Add missing prereqs to match use
The kwalitee tests on
[CPANTS](http://cpants.cpanauthors.org/dist/Dist-Zilla-Plugin-GitHubREADME-Badge)
show that some modules are used but not declared as prerequisites.  This
change brings code up to date and thus closes the prereq_matches_use
CPANTS core issue for this distribution.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Nov 10, 2016

Contributor

After having fixed the merge conflicts locally, something still seems to be wrong here as GitHub is still saying that the branch has conflicts WRT master. I'll close this as unresolved and submit a new PR.

Contributor

paultcochrane commented Nov 10, 2016

After having fixed the merge conflicts locally, something still seems to be wrong here as GitHub is still saying that the branch has conflicts WRT master. I'll close this as unresolved and submit a new PR.

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-missing-prereqs branch Nov 10, 2016

@paultcochrane paultcochrane restored the paultcochrane:pr/add-missing-prereqs branch Nov 10, 2016

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-missing-prereqs branch Nov 10, 2016

@paultcochrane paultcochrane restored the paultcochrane:pr/add-missing-prereqs branch Nov 10, 2016

@paultcochrane paultcochrane deleted the paultcochrane:pr/add-missing-prereqs branch Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment