Make PhaseReadme test package a package #28

Merged
merged 1 commit into from Apr 10, 2017

Conversation

Projects
None yet
4 participants
@paultcochrane
Contributor

paultcochrane commented Nov 11, 2016

... at least as far as Perl::Critic is concerned. In Perl::Critic at
severity level 4, the package declaration isn't found. The solution
was to move the strict and warnings pragmas below the package
declaration, hence silencing the Perl::Critic warning. The tests still
pass, so the intended behaviour seems to be the same.

Make PhaseReadme test package a package
... at least as far as Perl::Critic is concerned.  In Perl::Critic at
severity level 4, the `package` declaration isn't found.  The solution
was to move the `strict` and `warnings` pragmas below the `package`
declaration, hence silencing the Perl::Critic warning.  The tests still
pass, so the intended behaviour seems to be the same.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Nov 11, 2016

Contributor

Beyond this commit, most of the Perl::Critic issues start to become overly pedantic, and I don't think they bring much value for the code changes required (e.g. add missing return statements, unpack @_ in subs, etc). In fact, changing some of the code would make it less clearer by making Perl::Critic happy.

The code looks great! I hope my (somewhat picky) changes have been of use!

Contributor

paultcochrane commented Nov 11, 2016

Beyond this commit, most of the Perl::Critic issues start to become overly pedantic, and I don't think they bring much value for the code changes required (e.g. add missing return statements, unpack @_ in subs, etc). In fact, changing some of the code would make it less clearer by making Perl::Critic happy.

The code looks great! I hope my (somewhat picky) changes have been of use!

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 11, 2016

Coverage Status

Coverage decreased (-0.02%) to 99.474% when pulling 2d61f87 on paultcochrane:pr/make-test-package-a-package into 7d29212 on fayland:master.

coveralls commented Nov 11, 2016

Coverage Status

Coverage decreased (-0.02%) to 99.474% when pulling 2d61f87 on paultcochrane:pr/make-test-package-a-package into 7d29212 on fayland:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 11, 2016

Current coverage is 93.40% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files            14         14          
  Lines           197        197          
  Methods           0          0          
  Messages          0          0          
  Branches         26         26          
==========================================
  Hits            184        184          
  Misses            1          1          
  Partials         12         12          

Powered by Codecov. Last update 7d29212...2d61f87

codecov-io commented Nov 11, 2016

Current coverage is 93.40% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files            14         14          
  Lines           197        197          
  Methods           0          0          
  Messages          0          0          
  Branches         26         26          
==========================================
  Hits            184        184          
  Misses            1          1          
  Partials         12         12          

Powered by Codecov. Last update 7d29212...2d61f87

@fayland fayland merged commit 9e2f9ab into fayland:master Apr 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment