Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a number of issues #11

Merged
merged 11 commits into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@JJ
Copy link
Contributor

JJ commented Mar 29, 2018

Without touching the code, address some metadata issues, including some CPANTs problems.
I don't know if changing the command line will have an impact on the Code::TidyAll::Plugin::JSBeautifier module, because it's calling the script with options. Best check it and/or include it as part of the tests (if it's not already)

@fayland fayland merged commit da88fb2 into fayland:master Mar 29, 2018

@fayland

This comment has been minimized.

Copy link
Owner

fayland commented Mar 29, 2018

what's your PAUSE id? we can make you the co-maintainer so that you can do a release to PAUSE?

Thanks

@JJ

This comment has been minimized.

Copy link
Contributor Author

JJ commented Mar 29, 2018

@fayland

This comment has been minimized.

Copy link
Owner

fayland commented Mar 29, 2018

Added JMERELO to co-maintainers of JavaScript::Beautifier.

thanks for all the help. I also made you PUSH permission on this repos. you can merge your PR directly if needed.

Thanks

@JJ

This comment has been minimized.

Copy link
Contributor Author

JJ commented Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.