Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Instructions in README.md are broken #107

Closed
qrilka opened this Issue Oct 4, 2012 · 10 comments

Comments

Projects
None yet
3 participants

qrilka commented Oct 4, 2012

--autorun was removed in #95 and even with this flag removed I can not run the example:

$ cabal-dev/bin/fay examples/console.hs
fay: <command line>: cannot satisfy -package fay
    (use -v for more information)

And there is no flag -v for fay

Owner

chrisdone commented Oct 4, 2012

The -v comes from ghc. You have to compile with --no-ghc with cabal-dev. I'll update the README.

@chrisdone chrisdone closed this in 101114b Oct 4, 2012

qrilka commented Oct 4, 2012

Thanks, BTW is it OK that only 38 out of 78 fay-tests pass? Tag 0.9.1.0 shows the same result for me - aren't versions supposed to be somewhat stable?

Owner

chrisdone commented Oct 4, 2012

They are somewhat stable. It depends which tests are failing. If it's the unicode ones you don't have to worry about it.

Owner

bergmark commented Oct 5, 2012

I'd say they are very stable :) Don't know of any commits to master that broke the testsuite

qrilka commented Oct 5, 2012

         Test Cases   Total       
 Passed  39           39          
 Failed  48           48          
 Total   87           87 

in fay-tests does not look OK imho

Owner

bergmark commented Oct 5, 2012

Hmm... Please paste the error output

Test Cases Total Passed 86 86 Failed 0 0 Total 86 86

qrilka commented Oct 5, 2012

See https://gist.github.com/3842033 - maybe I should open a new issue for that?

Owner

bergmark commented Oct 6, 2012

Sure, perhaps someone else has a clue. Looks like it's the tests in tests/, check if they produce js output (they also end up in tests/) and what their contents are. And you can try running the js files manually with node to see if they output anything other than ""

qrilka commented Oct 6, 2012

Ooops, you don't say anywhere explicitly than node is needed. Having installed it I get 87/87

Owner

chrisdone commented Oct 6, 2012

It says it on the web site but not on the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment