This patch fixes authenticating through a yml file. It can now be done like this:
authenticated :config => "github.yml" do
Before the .gitconfig contents were always overriding the yml file.
fixing authentication with yml file
Hello, firstly: thank you very much for the patch. I have a couple of comments though, and I will add them now.
Commit claims to be "fixing authentication with yml file" but is actually making this change.
Not everyone is going to be using this with Rails, please just leave it as github.yml.
gotcha. I think i was just doing this as a way to document how to do it through rails. It's not clear that the yml file needs to be in the same directory but maybe that's just me
This line assigns the variable config twice (our problem, not yours, but I only just noticed it), and we could accomplish the same thing by using YAML.load_file(options[:config]) instead.
not sure i understand what you mean. how would you authenticate with the gitconfig file then? by passing the path to the gitconfig file through options[:config]?
oh nm i gotcha. about to make another commit
Does this file have a test against it?
you're right, i thought the tests were using it, but i just realized that there's a test/.gitconfig.. will remove
slight refactor for fixing authentication through yml file
let me know if you think my pull request needs anything else
Nope, looks good. I'll merge now.