Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Clarify text in the Messaging/Notification section #106
escowles left a comment
Most Hydra repositories do not use messaging now, so from the Hydra perspective, this change is unlikely to impact us one way or the other.
I agree with @barmintor that this looks like a nomenclature change, and the requirements for when notifications are generated and what they contain look equivalent, and the text is considerably streamlined too.
General sense seems fine although I think it would be nice to keep the following two clarifications:
I assume these are taken as implied still, but I prefer making them explicit.
I'm fine with dropping persisted to durable storage down to persisted (in whatever notion of persisted a particular implementation has). However, if we want to allow a much broader scope of events that generate notifications we should say something about that. As currently written the text is all about emitting notifications for resource changes. If there is agreement to extend that to other conditions then there should be changes along the lines of