Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Code cleanup #17

Closed
wants to merge 22 commits into
from

Conversation

Projects
None yet
2 participants

acoburn commented Nov 19, 2014

https://www.pivotaltracker.com/s/projects/684825/stories/82225792

This brings unit tests to ~ 90% coverage and addresses a number of issues identified by sonar.

Owner

awoods commented Nov 19, 2014

I am getting merge conflicts when taking this PR and doing "rebase master".

acoburn commented Nov 19, 2014

I'll try squashing those commits so you don't need to rebase anything

Owner

awoods commented Nov 19, 2014

You still need to rebase on master before a merge is possible.

acoburn commented Nov 19, 2014

This PR is a bit screwy. I'll send along another (cleaner) one.

@acoburn acoburn closed this Nov 19, 2014

@acoburn acoburn deleted the acoburn:CodeCleanup branch Nov 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment