Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Additional unit tests #18

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
2 participants

acoburn commented Nov 19, 2014

https://www.pivotaltracker.com/s/projects/684825/stories/82225792

This brings unit tests to ~ 90% coverage and addresses a number of issues identified by sonar.

Owner

awoods commented Nov 19, 2014

Pulling down your PR, then running "git rebase master" still shows conflicts.
Can you run "git rebase master" on your branch? If so, can you then resubmit this PR or create a new PR with the merge conflicts resolved?

acoburn commented Nov 19, 2014

I'll clean this up and resubmit tomorrow

@acoburn acoburn closed this Nov 20, 2014

@acoburn acoburn deleted the acoburn:UnitTests branch Dec 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment