Skip to content
Permalink
Browse files

add javadocs and remove the checkstyle suppression

  • Loading branch information...
cbeer committed Jul 4, 2013
1 parent 00822be commit 98d583cfbac5b09c321218e798b6c0e051f699e7

This file was deleted.

Oops, something went wrong.
@@ -154,14 +154,6 @@
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<consoleOutput>true</consoleOutput>
<configLocation>fcrepo-checkstyle/checkstyle.xml</configLocation>
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
@@ -32,6 +32,11 @@

private boolean isAuthorized;

/**
* Initialize the decision for a client and principal
* @param client
* @param principal
*/
public Decision(final String client, final String principal) {
this.oAuthClient = new OAuthClient() {

@@ -66,6 +71,10 @@ public boolean isAuthorized() {
return isAuthorized;
}

/**
* Set whether the principal is authorized
* @param isAuthorized
*/
public void setAuthorized(final boolean isAuthorized) {
this.isAuthorized = isAuthorized;
}
@@ -86,6 +86,10 @@ public OAuthDecision validateRequest(final String rsId, final String token,
return null;
}

/**
* Test wiring, so w e can set the sessionFactory field without spring
* @param sessionFactory
*/
public void setSessionFactory(final SessionFactory sessionFactory) {
this.sessionFactory = sessionFactory;
}
@@ -76,9 +76,8 @@
* @throws RepositoryException
*/
@GET
public Response getAuthorization(@Context
final HttpServletRequest request) throws URISyntaxException,
OAuthSystemException, RepositoryException {
public Response getAuthorization(@Context final HttpServletRequest request)
throws URISyntaxException, OAuthSystemException, RepositoryException {

OAuthAuthzRequest oauthRequest = null;

@@ -86,9 +86,8 @@
@POST
@Consumes(APPLICATION_FORM_URLENCODED)
@Produces(APPLICATION_JSON)
public Response getToken(@Context
final HttpServletRequest request) throws OAuthSystemException,
RepositoryException {
public Response getToken(@Context final HttpServletRequest request) throws
OAuthSystemException, RepositoryException {
LOGGER.debug("Received request for token carried on request: {}",
request);
OAuthTokenRequest oauthRequest = null;
@@ -244,6 +243,10 @@ private boolean isNotValid() {
return false;
}

/**
* Create the OAuth workspace in JCR to store all our tokens
* @throws RepositoryException
*/
@PostConstruct
public void init() throws RepositoryException {
createOauthWorkspace(sessions);
@@ -35,9 +35,8 @@
* @param sessionFactory
* @throws RepositoryException
*/
public static void
createOauthWorkspace(final SessionFactory sessionFactory)
throws RepositoryException {
public static void createOauthWorkspace(final SessionFactory sessionFactory)
throws RepositoryException {
final Session session = sessionFactory.getSession();
try {
if (!copyOf(session.getWorkspace().getAccessibleWorkspaceNames())

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.
@@ -64,12 +64,20 @@

private Set<ParameterStyle> parameterStyles;

/**
* no-op
*/
@PostConstruct
public void init() {
LOGGER.debug("Initializing {}", getClass().getName());

}

/**
* no-op
* @param filterConfig
* @throws ServletException
*/
@Override
public void init(final FilterConfig filterConfig) throws ServletException {
init();
@@ -131,6 +139,9 @@ public Principal getUserPrincipal() {

}

/**
* noop
*/
@Override
public void destroy() {

@@ -196,8 +207,7 @@ public void setProvider(final OAuthRSProvider provider) {
/**
* @param parameterStylesSet
*/
public void
setParameterStyles(final Set<ParameterStyle> parameterStylesSet) {
public void setParameterStyles(final Set<ParameterStyle> parameterStylesSet) {
this.parameterStyles = parameterStylesSet;
}

@@ -47,6 +47,9 @@ public void init(final FilterConfig filterConfig) throws ServletException {
init();
}

/**
* no-op
*/
@PostConstruct
public void init() {
LOGGER.debug("Initialized {}", this.getClass().getName());

0 comments on commit 98d583c

Please sign in to comment.
You can’t perform that action at this time.