Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced logging #342

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@escowles
Copy link
Contributor

commented May 6, 2014

  • Fixes https://www.pivotaltracker.com/story/show/69859530
  • Greatly reduced logging output by default (no graph dumps, only stacktraces generated by testing exception handling)
  • Standardized logging levels across projects
  • Added system properties to control log level globally or for each package:

log.fcrepo
log.fcrepo.auth
log.fcrepo.connector.file
log.fcrepo.generator.dublincore
log.fcrepo.http.api
log.fcrepo.http.commons
log.fcrepo.jms
log.fcrepo.kernel
log.fcrepo.storage.policy
log.fcrepo.transform

escowles added some commits May 6, 2014

Configuring logging to INFO level by default, reducing error messages…
… and stacktraces, changing handled exception logging to info instead of warn
<appender-ref ref="STDOUT"/>
</logger>
<logger name="org.fcrepo.kernel.observer" additivity="false" level="DEBUG">
<logger name="org.fcrepo.kernel.observer" additivity="false" level="${log.fcrepo:-INFO}">

This comment has been minimized.

Copy link
@awoods

awoods May 6, 2014

Member

The level is probably a cut and paste error.

This comment has been minimized.

Copy link
@escowles

escowles May 6, 2014

Author Contributor

I set these to be INFO by default, even though it's different from what the old behavior was, to be more consistent across packages. My thinking was that if debugging the JMS code requires debug output from those other packages, then it could be configured with System properties. Should I put these defaults back to INFO?

@@ -81,7 +81,7 @@ public String getValue() {
* home directory
*/
public void loadSystemProperties() {
LOGGER.info("Loading properties");
LOGGER.debug("Loading properties");

This comment has been minimized.

Copy link
@awoods

awoods May 6, 2014

Member

I would prefer to keep these at INFO. It is important to know the basic config of the repository at startup.

@@ -101,7 +101,7 @@ public void loadSystemProperties() {

for (final PROPERTIES prop : PROPERTIES.values()) {
final String val = prop.getValue();
LOGGER.info("{} = {}", val, getProperty(val));

This comment has been minimized.

Copy link
@awoods

awoods May 6, 2014

Member

I would prefer to keep these at INFO. It is important to know the basic config of the repository at startup.

@awoods

This comment has been minimized.

Copy link
Member

commented May 6, 2014

@awoods awoods closed this May 6, 2014

@awoods awoods deleted the reduced-logging branch May 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.