Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Modeshape 4.0.Alpha4 #433

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@escowles
Copy link
Contributor

commented Aug 6, 2014

escowles added some commits Aug 6, 2014

Manually porting many of @Cabeer's modeshape40 b/c kernel/kernel-impl…
… reorg made rebasing modeshape40 branch very messy
Updating configs, fixing len/newlen bug in CacheLoaderChunkInputStrea…
…m and updating JQL query in JQLConverterIT
@@ -6,20 +6,6 @@
"default" : "default",
"allowCreation" : true
},
"query" : {

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

@escowles, do you know how/where/if the ModeShape indexing is enabled/disabled/configured in 4.0?

This comment has been minimized.

Copy link
@escowles

escowles Aug 6, 2014

Author Contributor

@awoods: the Modeshape 4.0 guides says you can configure indexing:

https://docs.jboss.org/author/display/MODE40/Getting+Started#GettingStarted-ConfiguringaModeShaperepository

But (even after fixing the invalid JSON so it parses), that gives an error saying that "query" isn't defined and not allowed. So I guess I'll file a Modeshape bug for that.

* Get access to the important properties in the Modeshape Binary Metadata
* @author cabeer
*/
public class ChunkBinaryMetadata {

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

Unit test required

* @param binaryStore
* @return
*/
public static Cache<String, byte[]> getBlobCache(final InfinispanBinaryStore binaryStore) {

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

Remove uncalled method

* Utilities for gaining access to InfinispanBinaryStore internals
* @author cabeer
*/
public class InfinispanUtils {

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

Unit test required

@@ -64,7 +60,6 @@
@Mock
private BinaryStorage mockStorage;

@Mock
private InfinispanBinaryStore mockStore;

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

Since mockStore is only used in a single method, make it a local variable.

@@ -1,6 +1,6 @@
<infinispan xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

This file can be deleted, along with: "fcrepo-kernel-impl/src/test/resources/test_selfhealing_repository.json"

@@ -77,6 +77,11 @@
<artifactId>modeshape-jcr-api</artifactId>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>

This comment has been minimized.

Copy link
@awoods

awoods Aug 6, 2014

Member

Remove tabs, and
remove (instead, add jackson-core-asl to the top-level pom.xml dependencyManagement)

@awoods

This comment has been minimized.

Copy link
Member

commented Aug 7, 2014

Resolved with: 3c12712

@awoods awoods closed this Aug 7, 2014

@awoods awoods deleted the modeshape-40-alpha6-fresh branch Aug 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.