Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove datastream references from HTML UI controls #600

Merged
merged 1 commit into from Oct 30, 2014

Conversation

Projects
None yet
3 participants
@awoods

This comment has been minimized.

Copy link
Member

commented Oct 29, 2014

One implication of this PR is that the user would be unable to create the description of a non-rdf resource without also creating the non-rdf resource itself.
We need to be able to support the case where the non-rdf resource lives in a federation but the resource description lives in the repository.

@cbeer

This comment has been minimized.

Copy link
Member Author

commented Oct 29, 2014

We were never able to create a non-rdf resource description on its own.

@awoods

This comment has been minimized.

Copy link
Member

commented Oct 29, 2014

@cbeer

This comment has been minimized.

Copy link
Member Author

commented Oct 29, 2014

You're not making a non-rdf resource description there. You're making a empty binary resource. You'll find you get the same result if you give it any non-RDF content-type.

@escowles

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2014

We were always creating an empty binary resource -- and I'm fine with that. It's not a huge burden to create the empty binary. Providing the redirect is also very easy to do, and provides seamless retrieval of the external content in a way that's transparent to the user.

@cbeer cbeer force-pushed the remove-html-datastream branch from 7880667 to b18ae21 Oct 30, 2014

awoods added a commit that referenced this pull request Oct 30, 2014

Merge pull request #600 from fcrepo4/remove-html-datastream
Remove datastream references from HTML UI controls

@awoods awoods merged commit f974ea1 into master Oct 30, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@awoods awoods deleted the remove-html-datastream branch Oct 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.