Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use message/external-body MIME type for registering 'redirect' binaries #614

Merged
merged 1 commit into from Oct 31, 2014

Conversation

Projects
None yet
2 participants
@cbeer
Copy link
Member

commented Oct 30, 2014

Here's an idea for handling "redirect" binaries. I think it's a nice compromise between the empty-binary-with-a-special-property and creating a whole new type of thing.

Plus, I don't think we abuse the MIME type too much: https://tools.ietf.org/html/rfc2017

https://www.pivotaltracker.com/story/show/81770804

@cbeer cbeer force-pushed the external-body branch 3 times, most recently from 6b73765 to 0e1a10e Oct 30, 2014

@@ -116,6 +117,7 @@
public abstract class ContentExposingResource extends FedoraBaseResource {

private static final Logger LOGGER = getLogger(ContentExposingResource.class);
public static final MediaType MESSAGE_EXTERNAL_BODY = MediaType.valueOf("message/external-body");

This comment has been minimized.

Copy link
@awoods

awoods Oct 31, 2014

Member

I assume "message/external-body" is a completely fabricated mediatype. In which case, should it not be in either the "vendor tree" (vnd) or "personal tree" (prs)?
http://en.wikipedia.org/wiki/Internet_media_type#Vendor_tree

This comment has been minimized.

Copy link
@cbeer

cbeer Oct 31, 2014

Author Member

No, it is not fabricated:

Plus, I don't think we abuse the MIME type too much: https://tools.ietf.org/html/rfc2017

@cbeer cbeer force-pushed the external-body branch from 0e1a10e to 23e6d9a Oct 31, 2014

@cbeer cbeer force-pushed the external-body branch from 23e6d9a to f8a4cc8 Oct 31, 2014

awoods added a commit that referenced this pull request Oct 31, 2014

Merge pull request #614 from fcrepo4/external-body
Use message/external-body MIME type for registering 'redirect' binaries

@awoods awoods merged commit 96c79ef into master Oct 31, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@awoods awoods deleted the external-body branch Oct 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.