Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Revert "Update fcr:fixity to produce asynchronous responses" #662

Merged
merged 1 commit into from Nov 19, 2014

Conversation

Projects
None yet
3 participants
Contributor

mikedurbin commented Nov 19, 2014

This reverts commit 25f6722.

Owner

cbeer commented Nov 19, 2014

Why?

Contributor

mikedurbin commented Nov 19, 2014

https://www.pivotaltracker.com/story/show/82974300 Didn't work for some user... and I guess we're so close to the wire, temporary removal seems more prudent than debugging.

Owner

awoods commented Nov 19, 2014

Exactly. The serverside async processing does not work with Tomcat 7.0.52 out of the box installs, nor with default setups with certain Jetty versions.

  • Jetty 7 was Servlet 2.5 (no async)
  • Jetty 8 was Servlet 3.0 (async introduced) - spec was vague on what was default, so Jetty defaulted to async-supported == true
  • Jetty 9 is Servlet 3.1 (even more async) - the spec was clarified, and jetty chose its default poorly. The default according to the spec is async-supported == false

Given the minimal benefit of async fixity checks and the certain confusion and email traffic debugging community issues, it does not seem worth it.

awoods added a commit that referenced this pull request Nov 19, 2014

Merge pull request #662 from mikedurbin/revert-async-fixity
Revert "Update fcr:fixity to produce asynchronous responses"

@awoods awoods merged commit cad40fb into fcrepo4:master Nov 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment