Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LDP indirect containers to update referenced container #740

Merged
merged 2 commits into from Mar 6, 2015

Conversation

Projects
None yet
3 participants
@awoods
Copy link
Member

commented Mar 1, 2015

  • Handle 'insertedContainerProperty' that has been converted to a reference property
  • Provide current session to RdfContexts when constructed in FedoraResourceImpl

Resolves: https://jira.duraspace.org/browse/FCREPO-1383

Enable LDP indirect containers to update referenced container
* Handle 'insertedContainerProperty' that has been converted to a reference property
* Provide current session to RdfContexts when constructed in FedoraResourceImpl

Resolves: https://jira.duraspace.org/browse/FCREPO-1383
@cbeer

This comment has been minimized.

Copy link
Member

commented Mar 1, 2015

@awoods I'm confused about:

Handle 'insertedContainerProperty' that has been converted to a reference property

Are we trying to deal with a scenario when the value of the ldp:insertedContentRelation is within the repository namespace, or something else? Maybe I'm just missing the connection between the LdpContainerRdfContext change and the test you added..

@awoods

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2015

The basic issue is that the property provided in ldp:insertedContentRelation is not a REFERENCE type property, usually. The insertedContainerProperty https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/rdf/impl/LdpContainerRdfContext.java#L140 (e.g. info:proxy/for) is actually persisted on the resource as "info:proxy/for_ref"

Therefore, when the "info:proxy/for" property is requested, https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-kernel-impl/src/main/java/org/fcrepo/kernel/impl/rdf/impl/LdpContainerRdfContext.java#L187 , it is not found.

If you remove the updates from LdpContainerRdfContext and just run the new integration test, you will see that the implementation in master does not currently support IndirectContainers.

barmintor added a commit that referenced this pull request Mar 6, 2015

Merge pull request #740 from awoods/fcrepo-1383
Enable LDP indirect containers to update referenced container

@barmintor barmintor merged commit 5c6c6f5 into fcrepo4:master Mar 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.