Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCREPO-1599 #820

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@ajs6f
Copy link
Contributor

commented Jun 25, 2015

Minor use of Java 8 syntax and types in kernel observation code.

@ajs6f ajs6f force-pushed the ALittleJava8 branch from d09ce5a to 14382bb Jun 25, 2015

@ajs6f ajs6f force-pushed the ALittleJava8 branch from 14382bb to 0588796 Jun 25, 2015


@Override
public boolean apply(final Event event) {
public boolean test(final Event event) {

This comment has been minimized.

Copy link
@acoburn

acoburn Jun 25, 2015

Contributor

Is this class actually used anywhere? Can it be entirely removed?

This comment has been minimized.

Copy link
@ajs6f

ajs6f Jun 25, 2015

Author Contributor

I don't think it is, I think it was left as an example. I have no brief for it. @awoods ?

This comment has been minimized.

Copy link
@awoods

awoods Jun 25, 2015

Member

This class has served its purpose... and deserves to be laid to rest. Drop the monkey on it.

This comment has been minimized.

Copy link
@acoburn

acoburn Jun 25, 2015

Contributor

@ajs6f feel free to remove this class in this PR; otherwise, removing it can be part of a separate PR.

This comment has been minimized.

Copy link
@ajs6f

ajs6f Jun 26, 2015

Author Contributor

I'll add a commit with the excision. Monkeys? That's all Fedora needs. Monkeys in the codebase.

* the final type of the emitted FedoraEvent. TODO stop aggregating events in
* the heap and make this a purely iterative algorithm, if possible
* Maps all JCR {@link Event}s concerning one JCR node to one {@link FedoraEvent}. Adds the types of those JCR events
* together to calculate the final type of the emitted FedoraEvent. <br/>

This comment has been minimized.

Copy link
@acoburn

acoburn Jun 25, 2015

Contributor

This <br/> tag causes an error with mvn javadoc:jar (which is why travis fails). If you could remove it, I think this PR is good to go.

This comment has been minimized.

Copy link
@ajs6f

ajs6f Jun 26, 2015

Author Contributor

Really? That's illegal now? Oh, well. I'll take it out. I wonder how you're supposed to do that kind of formatting now...

@ajs6f

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2015

Made changes: kill NOOPFilter and AllNodeEventsOneEvent Javadoc fix.

@ajs6f ajs6f force-pushed the ALittleJava8 branch from 8265ab9 to b02cbd1 Jun 26, 2015

@awoods

This comment has been minimized.

Copy link
Member

commented Jun 29, 2015

Resolved with: aa8748b

@awoods awoods closed this Jun 29, 2015

@awoods awoods deleted the ALittleJava8 branch Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.