New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-on to https://jira.duraspace.org/browse/FCREPO-1667 #890

Merged
merged 1 commit into from Aug 21, 2015

Conversation

Projects
None yet
2 participants
@awoods
Member

awoods commented Aug 21, 2015

Remove use of Jena-atlas runtime exception,
...which added a non-OSGi friendly dependency.

@acoburn

This comment has been minimized.

Contributor

acoburn commented Aug 21, 2015

@awoods it's not that jena.atlas is not OSGi friendly, but rather that there is a transitive dependency clash:

fcrepo-camel depends on clerezza to do some rdf (de-)serialization, and that in turn depends on a wrapped version of jena (version 2.11), which does not contain that particular o.a.jena.atlas class. So, when fcrepo4 is launched for the integration tests, the class loader can't find the jena.atlas class in question, since it doesn't exist in the wrapped clerezza bundles.

That is to say, this proposed change is fine, but perhaps we should address it with a change in the camel component -- though doing so is a bit more complex.

@awoods

This comment has been minimized.

Member

awoods commented Aug 21, 2015

@acoburn, I will leave it up to you if you would prefer handling this with the current PR or doing something else within fcrepo-camel.

@awoods

This comment has been minimized.

Member

awoods commented Aug 21, 2015

Personally, pushing the exception handling down from FedoraLdp into ContentExposingResource seems like an improvement in any case.

@acoburn

This comment has been minimized.

Contributor

acoburn commented Aug 21, 2015

@awoods I'll take a look at how complicated a fix for this in the camel component. Either way, I agree with you that moving the exception handling to ContentExposingResource is a good thing.

Follow-on to https://jira.duraspace.org/browse/FCREPO-1667
Move exception handling from FedoraLdp into ContentExposingResource

@acoburn acoburn merged commit 59defcb into fcrepo4:master Aug 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment