Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widgets/gauge): apply label style and avoid overflow on large labels #494

Merged
merged 2 commits into from Jun 16, 2021

Conversation

fdehau
Copy link
Owner

@fdehau fdehau commented Jun 16, 2021

Description

Refactor the gauge render logic to fix two bugs:

  • the label style was not applied
  • using a label larger than the gauge width triggered a panic

Close #480

Testing guidelines

  • Two integration tests have been added
  • Run cargo run --example gauge

Checklist

@fdehau fdehau merged commit 8da5f74 into master Jun 16, 2021
4 checks passed
@fdehau fdehau deleted the gauge-label branch June 16, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling gauge label with foreground / background color has no effect
1 participant