Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Slack notifier #2

Merged
merged 2 commits into from Oct 20, 2019
Merged

Added Slack notifier #2

merged 2 commits into from Oct 20, 2019

Conversation

@anoopmadhav
Copy link
Contributor

anoopmadhav commented Oct 19, 2019

Issue: #1

Copy link
Owner

fdoxyz left a comment

Hello Anoop, I really appreciate the help and the PR looks great!

I left a comment on your commit though. I'll merge the PR as soon as you can make this small change. Thanks again for the help!

end

def slack_channel
@options['slack_channel'] or "#general"

This comment has been minimized.

Copy link
@fdoxyz

fdoxyz Oct 20, 2019

Owner
Suggested change
@options['slack_channel'] or "#general"
@options['slack_channel'] || "#general"

Since I've been using the || operator all around the project I would rather keep it consistent instead of using the or operator

lib/martilla/notifiers/slack.rb Outdated Show resolved Hide resolved
@anoopmadhav anoopmadhav requested a review from fdoxyz Oct 20, 2019
@fdoxyz
fdoxyz approved these changes Oct 20, 2019
@fdoxyz fdoxyz merged commit be2b04e into fdoxyz:master Oct 20, 2019
@fdoxyz

This comment has been minimized.

Copy link
Owner

fdoxyz commented Oct 20, 2019

Thanks again for the help @anoopmadhav!

Best of luck with the rest of Hacktoberfest. If you take a look at the repo in the coming days I might be adding some other issues in case you would be interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.