From 189afb9313d071c7b6492e0e8a996e6d073a2c6c Mon Sep 17 00:00:00 2001 From: sfc-gh-madkins <82121043+sfc-gh-madkins@users.noreply.github.com> Date: Thu, 8 Sep 2022 14:44:30 -0500 Subject: [PATCH] fix: Snowflake config file search error (#3193) Signed-off-by: Miles Adkins Signed-off-by: Miles Adkins --- sdk/python/feast/infra/materialization/snowflake_engine.py | 5 +---- sdk/python/feast/infra/offline_stores/snowflake.py | 4 +--- sdk/python/feast/infra/online_stores/snowflake.py | 5 +---- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/sdk/python/feast/infra/materialization/snowflake_engine.py b/sdk/python/feast/infra/materialization/snowflake_engine.py index 80deb13f96..de498fe4e1 100644 --- a/sdk/python/feast/infra/materialization/snowflake_engine.py +++ b/sdk/python/feast/infra/materialization/snowflake_engine.py @@ -2,7 +2,6 @@ import shutil from dataclasses import dataclass from datetime import datetime -from pathlib import Path from typing import Callable, List, Literal, Optional, Sequence, Union import click @@ -45,9 +44,7 @@ class SnowflakeMaterializationEngineConfig(FeastConfigBaseModel): type: Literal["snowflake.engine"] = "snowflake.engine" """ Type selector""" - config_path: Optional[str] = ( - Path(os.environ["HOME"]) / ".snowsql/config" - ).__str__() + config_path: Optional[str] = os.path.expanduser("~/.snowsql/config") """ Snowflake config path -- absolute path required (Cant use ~)""" account: Optional[str] = None diff --git a/sdk/python/feast/infra/offline_stores/snowflake.py b/sdk/python/feast/infra/offline_stores/snowflake.py index aab6871865..2395979702 100644 --- a/sdk/python/feast/infra/offline_stores/snowflake.py +++ b/sdk/python/feast/infra/offline_stores/snowflake.py @@ -64,9 +64,7 @@ class SnowflakeOfflineStoreConfig(FeastConfigBaseModel): type: Literal["snowflake.offline"] = "snowflake.offline" """ Offline store type selector""" - config_path: Optional[str] = ( - Path(os.environ["HOME"]) / ".snowsql/config" - ).__str__() + config_path: Optional[str] = os.path.expanduser("~/.snowsql/config") """ Snowflake config path -- absolute path required (Cant use ~)""" account: Optional[str] = None diff --git a/sdk/python/feast/infra/online_stores/snowflake.py b/sdk/python/feast/infra/online_stores/snowflake.py index a52beb73f7..be914043f2 100644 --- a/sdk/python/feast/infra/online_stores/snowflake.py +++ b/sdk/python/feast/infra/online_stores/snowflake.py @@ -2,7 +2,6 @@ import os from binascii import hexlify from datetime import datetime -from pathlib import Path from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple import pandas as pd @@ -31,9 +30,7 @@ class SnowflakeOnlineStoreConfig(FeastConfigBaseModel): type: Literal["snowflake.online"] = "snowflake.online" """ Online store type selector""" - config_path: Optional[str] = ( - Path(os.environ["HOME"]) / ".snowsql/config" - ).__str__() + config_path: Optional[str] = os.path.expanduser("~/.snowsql/config") """ Snowflake config path -- absolute path required (Can't use ~)""" account: Optional[str] = None