Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the foundation of the universal feature repo and a test that uses it #1734

Merged
merged 20 commits into from Aug 4, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jul 23, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
This PR that implements some of the basis of the universal feature repo as described in the the RFC

It adds a special decorator, parametrize_e2e_test, that makes it easy to tag tests to that should be executed against parameterized feature stores that are constructed by the testing framework. This means that users can add e2e tests and have them run against all supported combinations with a single decorator.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #1734 (c1cc8ad) into master (8f6e8df) will increase coverage by 0.79%.
The diff coverage is 95.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
+ Coverage   83.85%   84.65%   +0.79%     
==========================================
  Files          73       85      +12     
  Lines        6009     6268     +259     
==========================================
+ Hits         5039     5306     +267     
+ Misses        970      962       -8     
Flag Coverage Δ
integrationtests 84.57% <95.47%> (+0.79%) ⬆️
unittests 64.51% <55.55%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 92.62% <ø> (ø)
...ion/feature_repos/universal/data_source_creator.py 78.57% <78.57%> (ø)
...python/tests/integration/e2e/test_universal_e2e.py 85.36% <85.36%> (ø)
sdk/python/tests/data/data_creator.py 100.00% <100.00%> (ø)
...tegration/feature_repos/test_repo_configuration.py 100.00% <100.00%> (ø)
...n/feature_repos/universal/data_sources/bigquery.py 100.00% <100.00%> (ø)
...ation/feature_repos/universal/data_sources/file.py 100.00% <100.00%> (ø)
...n/feature_repos/universal/data_sources/redshift.py 100.00% <100.00%> (ø)
...ts/integration/feature_repos/universal/entities.py 100.00% <100.00%> (ø)
...tegration/feature_repos/universal/feature_views.py 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6e8df...c1cc8ad. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals force-pushed the achal/universal-feature-repo branch from ba00666 to 5879548 Compare August 2, 2021 16:22
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from tsotnet August 4, 2021 16:57
Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 7977a53 into feast-dev:master Aug 4, 2021
@achals achals deleted the achal/universal-feature-repo branch August 4, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants