Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with create-react-app #66

Closed
saiichihashimoto opened this issue Apr 13, 2018 · 3 comments
Closed

Use with create-react-app #66

saiichihashimoto opened this issue Apr 13, 2018 · 3 comments

Comments

@saiichihashimoto
Copy link

@saiichihashimoto saiichihashimoto commented Apr 13, 2018

Steps to reproduce

Using create-react-app with this module breaks the build.

I'm using @feathers/client rather than @feathers/feathers and, when I exclude this module, everything builds. With it, the build breaks.

Expected behavior

The create-react-app build should not break.

Actual behavior

It does break. :-P

image

It seems to have the same error as using @feathers/feathers does, ie something in @feathers/commons.

@daffl

This comment has been minimized.

Copy link
Member

@daffl daffl commented Apr 13, 2018

With create-react-app, use the ES5 build from feathers-localstorage/dist/feathers-localstorage instead.

@saiichihashimoto

This comment has been minimized.

Copy link
Author

@saiichihashimoto saiichihashimoto commented Apr 13, 2018

image

image

Doesn't really change much...

@daffl

This comment has been minimized.

Copy link
Member

@daffl daffl commented Apr 13, 2018

Well shoot, looks like some ES6 modules slipped through the transpilation step. Give it another go with the latest version 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.