Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #2

Merged
merged 3 commits into from Feb 27, 2016
Merged

Bug fix #2

merged 3 commits into from Feb 27, 2016

Conversation

@ekryski
Copy link
Member

ekryski commented Feb 27, 2016

This PR fixes:

  • get and find methods were not waiting for store to be ready
  • create will not throw a Conflict error if id exists anymore. Instead it updates more like a cache and localstorage is expected to work.
ekryski added a commit that referenced this pull request Feb 27, 2016
Bug fix
@ekryski ekryski merged commit c1fa6ca into master Feb 27, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ekryski ekryski deleted the bug-fix branch Feb 27, 2016

// If the item already exists then just update it.
if (this.store[id]) {
return this.update(id, data);

This comment has been minimized.

Copy link
@daffl

daffl Feb 27, 2016

Member

Eventually we may want to move this into feathers-memory.

This comment has been minimized.

Copy link
@ekryski

ekryski Feb 27, 2016

Author Member

Ya possibly. After I thought about it I think we can treat feathers-memory more like a database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.