Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make behaviour the same as normal database services again #7

Merged
merged 1 commit into from Mar 14, 2016

Conversation

@daffl
Copy link
Member

daffl commented Mar 12, 2016

I have some changes for feathers-authentication/client incoming which does not require feathers-localstorage to behave differently than the normal feathers-memory. This reverts the changes we had to do and closes #6.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 12, 2016

We'll need to test this React Native before we merge it.

@daffl

This comment has been minimized.

Copy link
Member Author

daffl commented Mar 12, 2016

This should work in RN as well since those changes were only hacks to work with arbitrary ids and creating when doing an update.

I think for authentication we should go back to a transparent storage abstraction like:

// use memory be default
// use localStorage
app.set('storage', window.localStorage);
// use AsyncStorage
app.set('storage', asyncStorage);
// use custom store
app.set('storage', {
  getItem(key) {},
  setItem(key, value) {}
});

For user and token storage so that we don't have to hack the behaviour of what is technically supposed to be a standard Feathers database service.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 14, 2016

:shipit:

ekryski added a commit that referenced this pull request Mar 14, 2016
Make behaviour the same as normal database services again
@ekryski ekryski merged commit a89cb11 into master Mar 14, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ekryski ekryski deleted the original-behaviour branch Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.