Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reusing names #77

Merged
merged 2 commits into from Sep 21, 2018
Merged

Prevent reusing names #77

merged 2 commits into from Sep 21, 2018

Conversation

@j2L4e
Copy link
Contributor

j2L4e commented Sep 21, 2018

Reusing storage keys leads to undefined behavior, so it shouldn't be possible.

This is a breaking change.
Although technically any application reusing storage keys could be considered broken already.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Sep 21, 2018

Thank you for fixing this!

@daffl daffl merged commit 342f16f into feathersjs-ecosystem:master Sep 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@j2L4e j2L4e deleted the j2L4e:name-reuse branch Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.