This repository has been archived by the owner. It is now read-only.

Bring back Cookie token extractor #55

Merged
merged 2 commits into from Jan 21, 2018

Conversation

Projects
None yet
2 participants
@daffl
Copy link
Member

daffl commented Jan 19, 2018

This pull request brings back parsing the JWT from the cookie. It will only be available if the cookieParser middleware has been registered (which we are not doing by default) and authentication cookies are enabled.

This change touches on many open issues, specifically in regards to using authentication for server side rendering and adding multiple accounts to the same user. Related issues:

@TimNZ

This comment has been minimized.

Copy link

TimNZ commented Jan 19, 2018

@daffl Legend. Mapping out authentication flows for various signup/login scenarios using mixed auth is #1 job right now so will dig into this shortly and provide feedback.

@daffl daffl merged commit 0fd4c2b into master Jan 21, 2018

5 checks passed

codeclimate All good!
Details
codeclimate/diff-coverage 88% (50% threshold)
Details
codeclimate/total-coverage 98% (0.1% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the extract-cookie branch Jan 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.