This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Adding tests and calling to hasOwnProperty on Object.prototype instead of assuming valid prototype #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for solving an issue with the hash-password hook.
The issue is that hash password hook assumes that the request body will come with a prototype associated which might not be the case, for example when used alongside multer, the request body gets regenerated with Object.create(null). This is not an issue with multer or any other library as is intended to avoid vulnerabilities.
The PR solves a undefined exception triggered on: ./lib/hooks/hash-password.js:40
There are no open issues related to this PR that I'm aware of.
No dependency on other PR on other repos.
Other Information
See: expressjs/multer#171 for more info