Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want the default success/fail routes, not the sendFile #121

Closed
saiichihashimoto opened this Issue Mar 24, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@saiichihashimoto
Copy link
Contributor

saiichihashimoto commented Mar 24, 2016

As of v0.6.0 the setUpSuccessRedirect and setUpSuccessRedirect parameters have been removed in favor of checking if the routes are equal to the defaults. So now I can't use /auth/success or /auth/failure with my own routes and are forced to have it send the public/auth-success.html and public/auth-fail.html files. There should be an option of using those defaults without being forced to have those specific html files.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Mar 24, 2016

Ah 💩 I knew there was a reason I had that in there but then @daffl made me second guess. My bad. I'll do a patch release for this, along with #122.

@ekryski ekryski added the Bug label Mar 24, 2016

@ekryski ekryski modified the milestone: 0.7 Mar 26, 2016

@ekryski ekryski referenced this issue Mar 30, 2016

Merged

0.7 Release #139

17 of 17 tasks complete

@ekryski ekryski closed this in b3bd9a2 Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.