Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all hooks optional if used internally #138

Closed
ekryski opened this Issue Mar 29, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@ekryski
Copy link
Member

ekryski commented Mar 29, 2016

Most of the hooks already do this. These ones need to be updated:

  • query with current user
  • associate with current user
  • hash password

@ekryski ekryski added the Task label Mar 29, 2016

@ekryski ekryski added this to the 0.7 milestone Mar 29, 2016

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Mar 29, 2016

It is possible for a user to overwrite params.provider so you run the risk of exposing unsecured methods to the outside world. Although unlikely we might want to investigate using Object.defineProperty so that it doesn't happen accidentally.

@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Mar 29, 2016

Sure. Let's create another issue for that though because that touches all the hooks and I don't want to block shipping in this in order to prevent someone from possibly screwing up their hooks.

@ekryski ekryski referenced this issue Mar 30, 2016

Merged

0.7 Release #139

17 of 17 tasks complete

@ekryski ekryski closed this in 2363314 Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.