Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make oauth2 more general #179

Closed
gurisko opened this Issue Apr 27, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@gurisko
Copy link

gurisko commented Apr 27, 2016

The current implementation is not very general:

  • assuming ${options.provider}Id field in a database
  • updating a user with all data returned by the passport strategy (link)

This could be solved by allowing to specify a provider field in a database and support a custom hooks.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Apr 28, 2016

The second issue is now resolved (yet to be released). I agree, any chance you want to put together a PR for allowing to specify a provider field?

@ekryski ekryski added the Task label Apr 28, 2016

@gurisko

This comment has been minimized.

Copy link
Author

gurisko commented Apr 28, 2016

@ekryski Definitely. I will look into this during the weekend.

@ekryski ekryski added the Backlog label May 21, 2016

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented May 21, 2016

@gurisko still waiting on that PR 😉 🙏

@ekryski ekryski added this to the 0.8 milestone May 21, 2016

@ekryski ekryski added ready and removed Backlog labels May 21, 2016

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Jul 19, 2016

This is still on the radar. Steps are being made to make it more general and at a minimum you'll soon be able to extend the service to have your own custom logic without having to rewrite the whole module or all of auth.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Oct 26, 2016

This is done and in 0.8-beta. Can be accessed and extended by doing this:

const OAuth2Service = require('feathers-authentication').OAuth2Service

class MyService extends OAuth2Service {

}

app.configure(MyService(options))

It is likely that this is moving to it's own repo https://github.com/feathersjs/feathers-authentication-oauth2

@ekryski ekryski closed this Oct 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.