Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 authentication callback failing due to missing property #196

Closed
nyaaao opened this Issue May 3, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@nyaaao
Copy link
Contributor

nyaaao commented May 3, 2016

I'm getting and error TypeError: Cannot set property 'accessToken' of undefined in https://github.com/feathersjs/feathers-authentication/blob/master/src/services/oauth2/index.js#L44 probably due to _json property is missing. Looking at other Strategies' implementation I see this in passport-facebook (set here: https://github.com/jaredhanson/passport-facebook/blob/master/lib/strategy.js#L179), but not, for example, in passport-google. My Strategy provider does not set it as well.

Can this be made conditional?

@ekryski ekryski added the Bug label May 3, 2016

nyaaao added a commit to nyaaao/feathers-authentication that referenced this issue May 3, 2016

@ekryski ekryski closed this in #197 May 5, 2016

ekryski added a commit that referenced this issue May 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.