Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses hang when token.secret is undefined for local authentication #249

Closed
petermikitsh opened this Issue Jul 28, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@petermikitsh
Copy link
Contributor

petermikitsh commented Jul 28, 2016

If authentication config value token.secret is set to null or undefined, successful local authentication attempts will hang. Unsuccessful authentication attempts will return 401 as expected.

Probably should yell at the developer for improper usage, perhaps with some sort of warning message :)

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Aug 4, 2016

Coming in the next 0.8 release. 😄 Thanks for reporting @petermikitsh!

@ekryski ekryski added this to the 0.8 milestone Aug 4, 2016

@ekryski ekryski modified the milestones: 0.8, 1.0 Nov 21, 2016

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Dec 30, 2016

This is now fixed in v1.x. If a token secret is falsey we toss an error on app startup.

@ekryski ekryski closed this Dec 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.