Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authenticating with Username and Password via sockets #32

Closed
ekryski opened this Issue Jan 25, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@ekryski
Copy link
Member

ekryski commented Jan 25, 2016

Currently we only support authentication via sockets once you have your JWT. We should support being able to send the username and password attributes via sockets and receive a JWT in response.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Jan 25, 2016

That was one of the things I started on when looking into oAuth. The authentication routes (see https://github.com/feathersjs/feathers-authentication/blob/master/src/index.js#L41) should probably simply be their own service. That way we'd get SocketIO authentication for free. /cc @marshallswain

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Jan 25, 2016

That's how I discovered this stuff about trading an unauthenticated socket for an authenticated one:

socket = io('', {
  // Assuming you've already saved a token to localStorage.
  query: 'token=' + localStorage.getItem('featherstoken'),
  transports: ['websocket'], // optional, see below
  forceNew:true,             // optional, see below
});
@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Jan 25, 2016

Sounds good. Keep #33 in mind.

@ekryski ekryski modified the milestone: 1.0 release Feb 2, 2016

@ekryski

This comment has been minimized.

Copy link
Member Author

ekryski commented Feb 7, 2016

This is done in the decoupling branch.

@ekryski ekryski referenced this issue Feb 12, 2016

Merged

Decoupling #49

@ekryski ekryski closed this in 4823671 Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.