Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 0.7.11 does not contain current code on NPMJS #342

Closed
joelkoz opened this Issue Nov 11, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@joelkoz
Copy link

joelkoz commented Nov 11, 2016

I just pulled a new copy of feathers from npmjs via 'npm install', as I noticed a bug I had reported (#301) had been fixed. Unfortunately, my local tests failed, and after a little investigation, I noticed that the "feathers-authentication/lib/hooks/restrict-to-owner.js" code does not appear to be from the same code that is in the master repo here on github. I wonder if perhaps there was a transpiler failure, and the lib file did not get updated with the correct code prior to "npm publish."

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Nov 11, 2016

You're right. I just verified with a new install:

{
  "name": "fcheck",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "feathers-authentication": "^0.7.11"
  }
}

It doesn't contain the code from that commit.

screen shot 2016-11-10 at 5 45 06 pm

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Nov 11, 2016

I republished a 0.7.12 and it should now contain the fix.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Nov 11, 2016

@daffl what was the deal?

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Nov 11, 2016

No idea. Maybe publishing failed and I didn't notice.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Nov 11, 2016

That's just what the doctor ordered. @joelkoz you should be able to use it, now. Thanks for alerting us!

{
  "name": "fcheck",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "feathers-authentication": "^0.7.12"
  }
}

screen shot 2016-11-10 at 9 09 08 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.