Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code in example app #383

Closed
heymartinadams opened this Issue Dec 22, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@heymartinadams
Copy link

heymartinadams commented Dec 22, 2016

Here: https://github.com/feathersjs/feathers-authentication/blob/master/example/app.js
Line 11: const auth = require('../lib/index');
Missing /lib folder.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Dec 22, 2016

@heymartinadams lib is actually a compiled folder. I think you run npm run compile to get it in place.

@heymartinadams

This comment has been minimized.

Copy link
Author

heymartinadams commented Dec 22, 2016

Gotcha, @marshallswain. Unfortunately, I wasn’t able to get it compiled. The npm command "compile": "rimraf -rf lib/ && babel -d lib/ src/" threw the following error.

ReferenceError: Unknown plugin "add-module-exports" specified in "/Users/martinadams/swifty/feathers-authentication/.babelrc" at 0, attempted to resolve relative to "/Users/martinadams/swifty/feathers-authentication"

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Dec 22, 2016

That's one of the devDependencies of feathers-authentication: https://github.com/feathersjs/feathers-authentication/blob/master/package.json#L67

Have you installed this directly from the repo? It doesn't sound like you've installed from npm. You probably need to cd node_modules/feathers-authentication && npm install.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Dec 22, 2016

If you run just the example, change

const auth = require('../lib/index');

to

const auth = require('feathers-authentication');
@heymartinadams

This comment has been minimized.

Copy link
Author

heymartinadams commented Dec 22, 2016

Thank you, @daffl and @marshallswain.

Unfortunately, I’m having trouble migrating to feathers-authentication 1.0. Would any of you perhaps be willing to take a look at it? It’s a private repo, so I’ll invite you to it if you like. Built entirely on feathersJS (which is awesome, by the way :)

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Dec 22, 2016

Absolutely. I can offer a couple minutes. My email's in my profile.

@heymartinadams

This comment has been minimized.

Copy link
Author

heymartinadams commented Dec 22, 2016

Thank you, @marshallswain! I’m mostly a font-end dev, so the back-end has been a bit of a challenge. I’ll also send you an email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.