Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighter integration with feathers-authentication-management #393

Closed
eddyystop opened this Issue Jan 6, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@eddyystop
Copy link
Member

eddyystop commented Jan 6, 2017

feathers-authentication-management adds a isVerified flag to user. That can be used in a service hook to check a user is verified, after any checking that the user is authenticated.

Still it looks a bit wierd that the feathers-authentication ecosystem will authenticate a user with isVerified === false. I wonder if that flag, if it exists, should be checked by the ecosystem.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Jan 6, 2017

We definitely need a better way to integrate. Is the user present in the hook object of an afterCreate hook on the authentication service? If so, we could just register an after hook that checks the user and throws an error to keep the token from going out.

@ekryski ekryski changed the title Integrate with isVerified flag added by feathers-authentication-management Tighter integration with feathers-authentication-management Jul 24, 2017

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Jul 24, 2017

I'd like to revisit this and look at tweaking feathers-authentication-management to be a bit more generic so that the user isn't required to define any specific model attributes. I see it being pretty minor tweaks and also easier once we have some of the work slated for Auth 2.0 complete.

@ekryski ekryski self-assigned this Jul 24, 2017

@daffl daffl closed this May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.