Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie-based authentication with XHR is not possible #413

Closed
adrien-k opened this Issue Feb 3, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@adrien-k
Copy link
Contributor

adrien-k commented Feb 3, 2017

In current implementation it is not possible to have the "set cookie" middleware over a XHR queries, because of https://github.com/feathersjs/feathers-authentication/blob/legacy/src/middleware/express.js#L76

Why not set the cookie first and handle the check xhr / check response content and content-type / successRedirect after ?

@adrien-k

This comment has been minimized.

Copy link
Contributor Author

adrien-k commented Feb 3, 2017

I've just checked the master branch where this is fixed, nevermind :)

@adrien-k adrien-k closed this Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.