Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body 'token' parameter disappears #420

Closed
Alendorff opened this Issue Feb 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@Alendorff
Copy link

Alendorff commented Feb 13, 2017

Using feathers-authentication 0.7.12.
In feathers-authentication\lib\middleware\express.js I found this code:

    // Check the body next if we still don't have a token
    if (req.body.token) {
      token = req.body.token;
      delete req.body.token;
    }

And same for req.params. I wanted to ask why you are removing the token from everywhere? I tried to use a token field in POST body for my custom middleware, and I was confused a bit when all the time the token disappeared on server-side . Is there some security reason or ... ?

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Feb 25, 2017

This was a bug in v0.x. If this is an issue I'd recommend trying to upgrade to v1.0.

@Alendorff

This comment has been minimized.

Copy link
Author

Alendorff commented Feb 25, 2017

Alright then, let's close it.

@Alendorff Alendorff closed this Feb 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.