Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme incorrect and maybe docs to #440

Closed
genyded opened this Issue Mar 9, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@genyded
Copy link

genyded commented Mar 9, 2017

The readme has:

import localstorage from 'feathers-localstorage'

... but that is never referenced anywhere else (and for us our linters also fail). 'window.localStorage' is used though and we'd fix the readme but it's unclear to us which which one should be used or if it matters. Also, what if the browser does not support localStorage?

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Mar 9, 2017

I think we can remove the line you've posted, above.

You can use any storage engine that implements the Web Storage API. For example, if your app needs to access localStorage while in Private Browser Mode, you can use https://github.com/localForage/localForage to fill that need.

@genyded

This comment has been minimized.

Copy link
Author

genyded commented Mar 9, 2017

We commented it out for now, but yes - one or the other should be used in the code and maybe a note added to clarify that any can be used.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Mar 9, 2017

The docs will cover the clarification. I'll just remove that line for now.

@genyded

This comment has been minimized.

Copy link
Author

genyded commented Mar 9, 2017

Cool and thanks as usual!

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Mar 9, 2017

done in 7663054

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Mar 9, 2017

Thanks @genyded! Every detail counts heaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.