Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event filtering by default (socket.io) #460

Closed
ghost opened this Issue Mar 23, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@ghost
Copy link

ghost commented Mar 23, 2017

"authentication created" events are propagated to everyone (with the accessToken), even with logged out users. I think this should be filtered/silenced by default.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Mar 23, 2017

@johncrisostomo That definitely needs to be addressed. Which version of feathers-authentication are you reporting on?

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 23, 2017

@marshallswain v1.1.1. Thanks @daffl for #461 , I am closing this now and I'll remove the custom filter from my project.

@ghost ghost closed this Mar 23, 2017

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.