Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename `app.authenticate()` to `app._authenticate()` #468

Closed
marshallswain opened this Issue Mar 31, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@marshallswain
Copy link
Member

marshallswain commented Mar 31, 2017

The authenticate method is only useful on the server for transport plugin developers. We are going to rename it to _authenticate to remove any confusion that it should be used for authentication in general. See #466 (comment) for more information

@ekryski ekryski self-assigned this Mar 31, 2017

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Apr 1, 2017

Does it have to be on app at all? It's just an alias for app.passport.authenticate right?

@marshallswain

This comment has been minimized.

Copy link
Member Author

marshallswain commented Apr 1, 2017

Yep, and it sets passport as the context, but that's all.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Apr 1, 2017

Either change could be breaking so we might as well remove it.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Apr 2, 2017

no I want to keep it, it should just be a "private" method. It is an alias for app.passport.authenticate but it calls it with passport as the context which is important and not something that I want anyone else to have to worry about as that requires internal knowledge of how passport and our adapter works. This method is only used if you are writing another transport adapter (which we may do in the future).

I've already done it. Will commit it later today.

@ekryski ekryski added the Task label Jul 24, 2017

@daffl daffl closed this Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.