Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.get('auth') vs app.get('authentication') #497

Closed
brenmcnamara opened this Issue May 6, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@brenmcnamara
Copy link

brenmcnamara commented May 6, 2017

Maybe I'm not understanding the code, but it seems that app.get(<something>) fetches from the relevant config file in the /config directory.

In the documentation here, it suggests the name of this config should be 'auth' for the authentication config. In addition, the code in feathers-authentication-local and feathers-authentication-jwt make the assumption that their configs can be fetched using app.get('auth'). However, when using the generator to generate the authentication service:

feathers generate authentication

The config file is modified to have an "authentication" config, not "auth". Is this correct?

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented May 7, 2017

I believe the modules default location needs to be updated.

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented May 10, 2017

Yes this was changed in the generator but was never updated in the auth modules. I think because the generator is set up to pass the auth configs explicitly this wasn't caught sooner. I have PRs coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.