Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogoutTimer not being cleared correctly #532

Closed
wnxhaja opened this Issue Jun 22, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@wnxhaja
Copy link
Contributor

wnxhaja commented Jun 22, 2017

I recently upgraded my feathers authentication from v1.2.2 to v1.2.4.

I am calling app.authenticate() on my client and expecting for the jwt expiry to update. I get the updated jwt token with the new expiry. But still I am being logout by the server because jwt token expires.

I look up the changelog and I found this fix #449. It is now using long-timeout in setting the logoutTimer but still using the old way of clearing timeout here. Then I change to lt.clearTimeout(logoutTimer) and it is now properly clearing the timeouts.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Jun 22, 2017

@wnxhaja thank you for reporting this issue. Would you be able to make a PR with your changes?

@wnxhaja

This comment has been minimized.

Copy link
Contributor Author

wnxhaja commented Jun 22, 2017

Sure!

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Jun 22, 2017

Closed via #534

@daffl daffl closed this Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.