Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tokenEndpoint failing #57

Closed
bedeoverend opened this Issue Feb 12, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@bedeoverend
Copy link

bedeoverend commented Feb 12, 2016

When I use a custom token endpoint, e.g. /login or /token, registering the before hook seems to throw an error. I'm pretty sure it's this line here.

Should it be instead: const tokenService = app.service(options.tokenEndpoint); ?

marshallswain added a commit that referenced this issue Feb 13, 2016

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Feb 13, 2016

Thanks! Good find.

@marshallswain

This comment has been minimized.

Copy link
Member

marshallswain commented Feb 13, 2016

The fix for this is published to npm as version 0.2.2

@bedeoverend

This comment has been minimized.

Copy link
Author

bedeoverend commented Feb 13, 2016

@marshallswain thanks!

@ekryski

This comment has been minimized.

Copy link
Member

ekryski commented Feb 13, 2016

@marshallswain thanks for fixing. I'll be writing tests for this stuff today.

@ekryski ekryski modified the milestone: 0.6 Mar 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.