Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in jwt default options #570

Closed
bnielsen1965 opened this Issue Sep 13, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@bnielsen1965
Copy link

bnielsen1965 commented Sep 13, 2017

There is what I assume is a type in the default jwt options...
https://github.com/feathersjs/feathers-authentication/blob/master/src/options.js#L17

It reads...
header: { typ: 'access' },

Perhaps it is meant to read...
header: { type: 'access' },

I haven't noticed anything broken in authentication but this looks like a bug waiting to pop out.

@daffl

This comment has been minimized.

Copy link
Member

daffl commented Sep 18, 2017

This is actually correct. JWT options have some strange abbreviations. Follow-up fix in the generator in feathersjs/generator-feathers#281

@daffl daffl closed this Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.